Skip to content
This repository has been archived by the owner on Jan 13, 2023. It is now read-only.

Support React-Navigation v2.3 #57

Merged
merged 2 commits into from
Sep 20, 2018

Conversation

gorhom
Copy link
Contributor

@gorhom gorhom commented Jun 20, 2018

Hi guys !

I have updated the React-Navigation to 2.3.1 and did some changes based on the react-navigation-redux-helpers

Thanks 👍

@nonameolsson
Copy link
Contributor

Great work, this must be included! @gorhom Have you had time to check the conflicting files?

* master:
  ⬆️ upgrades reactotron to latest version (infinitered#77)
  Fix typo and fix import path (infinitered#73)
  Remove unused import and update path (infinitered#72)
  Misc: Increment version to beta.2
  Update: replace sed command to plain js / fixed android path camelcase bug (infinitered#69)
  1.0.0-beta.1
  beta 0
  Changed version number
  Change bowser to beta (infinitered#64)
@gorhom
Copy link
Contributor Author

gorhom commented Sep 4, 2018

Thanks @nonameolsson , I have merge latest changes from master and fixed the conflicting files 👍

@nirre7
Copy link
Contributor

nirre7 commented Sep 11, 2018

+1 would love to get this update.

Bump

I'm working on a pull-request to bump the bowser boilerplate to RN 0.57 + a general bump of "all" dependencies. Would be great to have this merged so I can merge it with the version bump.
Thanks in advance.

@robinheinze
Copy link
Member

I'm going to take a look at this today and see if we can't get it merged soon.

@robinheinze
Copy link
Member

@gorhom Everything seems to work great! Any chance you've tried this with the latest version of react-navigation? (Which, as of today is I think 2.15.0)

@nirre7
Copy link
Contributor

nirre7 commented Sep 20, 2018

I tried 2.14.0 with @Gorhorms PR "manually patched in" on my bowser 0.57 pr / branch a couple of days ago and it seemed to work.

@robinheinze
Copy link
Member

I'm going to go ahead and merge this as-is. @nirre7 If you want to try bump it to 2.14.0 in your PR, feel free!

Thanks @gorhom!

@robinheinze robinheinze merged commit 040761c into infinitered:master Sep 20, 2018
@zakpgrove
Copy link

zakpgrove commented Sep 22, 2018

Hey, I'm trying to understand the new StatefulNavigator code. Under StatefulNavigator.render, why is the getScreenProps under getNavigation (5th argument) not a function like "() => ({})" and instead just "{}".

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants