Allow style arrays in HOCs (WIP)

[morgandonze]

See #79

I have enabled style arrays in HOC components, and I have provided Storybook examples for each.
The example styles are not meant to look good.

@derekgreenberg the "trick" I mentioned was this:

  if (Array.isArray(props.fillStyle)) {
    fillStyle = reduce((acc,term) => {
      return { ...acc, ...term }
    }, FILL, props.fillStyle)
  } else {
    fillStyle = { ...FILL, ...props.fillStyle } as ViewStyle
  }

to properly reduce the array style. I tried something before this that didn't work (something like the following):

ramda.mergeWith(ramda.concat, FILL, styleOverride)

(Not really a trick as much as simply doing it right instead of wrong)

[derekgreenberg]

Remove // here

[derekgreenberg]

For each of the component changes, you should provide a storybook example.

[derekgreenberg]

@mlaco pull from master, which has changes to a bunch of storybook stories. Then update storybook stories for each component you have modified here.

[skellock]

If you change our definitions from say ViewStyle to StyleProp<ViewStyle>, you might not need much of this code. I always just use ViewStyle instead of ViewStyle[] since it's easy to spread & overwrite things. I can't tell you when the last time I used an array for styles was.

React Native supports passing an {}, [], true, false, and StyleSheet.

And you can mix & match any of the above into an []. And that's what StyleProp does for us.

The only thing would need to change is how the style merging inside the components that add their own styling (like CheckBox). But you could use an array now since you can't spread it (since it's not a single object-based type).

Life is simpler with spreads, imo.

[morgandonze]

Hey @kevinvangelder, as you can see, I implemented this. But Steve brought up concerns
about adding unnecessary code, and I agree with it. Array styles don't appear
to provide any meaningful benefit.

I can’t think of a real reason someone would need an array style, and if they had some weird situation where they dynamically compute something that comes out as an array, they could just reduce it themselves.

Unfortunately I didn't consider the necessity before writing this PR, but I'm not sure merging it is the best idea. What are your thoughts?

[jamonholmgren]

I have seen array styles taught a lot in React Native courses. So, even though we don't necessarily use them in-house, it might make sense to still have examples of how to handle them here. Just my 2 cents.

[kevinvangelder]

I use arrays for styles almost everywhere. If I'm understanding Steve correctly we could still support array styles by just changing our types and making minor changes to the implementation? @skellock could you give us an example?

[morgandonze]

In honor of @skellock, I will commence with the merging of code he doesn't like 😉

[skellock]

Haha ❤️ All good. I may not be a fan but if many people are, then give 'er.