-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NavigatorExperimental Away Mission #29
Comments
is sorry. is fixed. 😺 |
@GantMan is on this. |
Hey @GantMan, are you still working on the Navigation Experimental? |
Hey @mmazzarolo :) I spent a whole 2 days fighting the new Navigation Experimental, and it just wasn't ready. It hurt so bad! LOL. I saw he was updating it every day, so I decided to give it a bit of time and back off. Now it might be time to come back. I'll start carving some time to venture off again. If anyone else wants to take a look, I'm happy to download what I've learned to them. |
@GantMan i toyed a bit with it this morning, it seems to be working fine in my project (still need to add a drawer and some more tricky routes). Disclaimer: I've stolen and then tweaked all that boilerplate from here 🐼 |
This is awesome, I'll check into this immediately. Also, this seems like a good opportunity if you want to get your name on the list of contributors to ignite ;) |
Yup, I've been a bit hesitant on contributing because I never tried the Ignite app itself, i only used the boilerplate. |
@GantMan, don't know if you're interested but I updated the Gist adding a native toolbar for both iOS and Android and the drawer. HOWEVER 👘 |
Man, you're my hero. I was just lining up this weekend to dive deep into re-writing the nav stack. I think if anything, I'll either hold off, or set the ground for you. I would love an ignite navigation best practices PR. |
@mmazzarolo - Any luck? I was thinking of taking a swing at this task this week. |
@GantMan, nope, I stopped working on it because currently replacing the stack is buggy, but we should have a fix soon. |
awesome, will wait for a bit :) as per your recommendation. |
Just a small update: still no updates. |
|
The current initial ignite base generator has empty drawer menu. from above discussion did any one has idea which way is a good way to create drawer menu? |
We've got drawers working with our current nav, but not with NavigatorExperimental, which is what this ticket is geared towards. Are you looking fora good example drawer in the initial ignite base? |
yes, I am looking for a good example of drawer menu in ignite base. there are several drawer menu react native. but I just wandering. which one is a good one to use so it integrate nicely to ignite base |
@steve21224 I'd go with |
good thanks. then I will reuse the react native drawer from http://caroaguilar.com/post/react-native-navigation-tutorial/ then..... also, if you have some snippet of your drawer menu integrate to ignite. feel free to share if you don't mind |
Finally, I got it. my left drawer menu be able to replace the main container page. _navigate(route) { this.navigator.resetTo(route); this.navigator.drawer.close(); } renderDrawerContent () { return ( View style={{marginTop: 30, padding: 10}}> RoundedButton onPress={() => this._navigate(Routes.PresentationScreen)}> Theme Screen RoundedButton> RoundedButton onPress={() => this._navigate(Routes.PresentationScreenB)}> Theme Screen RoundedButton> RoundedButton onPress={() => this._navigate(Routes.PresentationScreenC)}> Theme Screen RoundedButton> View> ) } and each presentation screen will have it own page. this will integrate nicely with ignite. |
Awesome @steve21124 If you'd like to do an example in a PR we'd be happy to accept it. |
Thank you. Yes, if I can put some time in writing the tutorial for it. it will let you know. From the ignite readme, I did not see there is generator for menu items. It might be cool. given a list of string array, using command "ignite generate menu 'Screen1,Screen2,Screen3,Screen4'". it will automatically create left drawer menu with the associate screen page from (ignite generate screen ...) |
I like that! Thoughts, @kevinvangelder and @skellock ? |
@GantMan, I'll try to submit a basic pr in two data if you're still interested |
i think. any pr that help. it will be great |
days*, not data |
I believe @skellock is slated to attack this this week. |
@steve21124 Just followed your instruction to add drawer menu content and that worked nicely but it makes the backbutton not working on the screen when we visit from the drawer menu item. Is the backbutton working fine for you? |
@steve21124 I replaced the below line on the _navigate() function, this.navigator.resetTo(route); After made this change, back button works but there are two problems.
Any idea how do we resolve this? |
#235 - solves how we're going to handle this. Going to close this ticket. |
<Navigator>
is sun-setting.<NavigatorExperimental>
is transitioning in (the name will change).I'm hearing nothing but great things about it. Redux like apparently.
Anyone up for spiking it through before its officially released? This is my only hesitation in picking a 3rd party library @ryanlntn for Navigation routing & presentation.
It's all about to change.
The text was updated successfully, but these errors were encountered: