Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade to Expo SDK 50 #2612

Merged
merged 15 commits into from
Feb 9, 2024
Merged

feat: upgrade to Expo SDK 50 #2612

merged 15 commits into from
Feb 9, 2024

Conversation

frankcalise
Copy link
Contributor

@frankcalise frankcalise commented Jan 19, 2024

Please verify the following:

  • yarn test jest tests pass with new tests, if relevant
  • README.md has been updated with your changes, if relevant

Describe your PR

Copy link
Contributor

@mazenchami mazenchami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

impressive work! 🎉 🚀

Copy link
Contributor

@Jpoliachik Jpoliachik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@@ -5,7 +5,7 @@ module.exports = {
...tsjPreset,
preset: "jest-expo",
transformIgnorePatterns: [
"<rootDir>/node_modules/(react-clone-referenced-element|@react-native-community|react-navigation|@react-navigation/.*|@unimodules/.*|native-base|react-native-code-push)",
"<rootDir>/node_modules/(?!((jest-)?react-native|@react-native(-community)?)|expo(nent)?|@expo(nent)?/.*|@expo-google-fonts/.*|react-navigation|@react-navigation/.*|@unimodules/.*|unimodules|sentry-expo|native-base|react-native-svg|react-clone-referenced-element|react-native-code-push)",
Copy link
Collaborator

@flexbox flexbox Jan 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to make it more readable here is a little hack I use

const packagesToTransform = [
  "react-native",
  "react-native-(.*)",
  "@react-native",
  "@react-native-community",
  "@react-navigation",
  "expo",
  "expo-(.*)",
  "react-native-svg",
  "@sentry/.*",
];

/**
 * @type {import('@jest/types').Config.InitialOptions}
 * */
const config = {
  preset: "jest-expo",
  // ...
  transformIgnorePatterns: [
    `node_modules/(?!(${packagesToTransform.join("|")})/)`
  ],
};

module.exports = config;

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this a lot! So much more readable!

@mattiaferrari02
Copy link

I scaffolded a new project from this PR, testing the eas developmnent build does not work. Why did you guys even approve this without trying a build. I hate you all.

@flexbox
Copy link
Collaborator

flexbox commented Feb 1, 2024

@mattiaferrari02 nice, can you give us a reproductible repository we can dig on?

And share the stack trace from expo dashboard 🙏

@frankcalise
Copy link
Contributor Author

frankcalise commented Feb 1, 2024

I scaffolded a new project from this PR, testing the eas developmnent build does not work. Why did you guys even approve this without trying a build. I hate you all.

Ciao @mattiaferrari02 ! Alcuni punti:

  1. While approved, it is not merged
  2. Providing the error message you ran into would help us actually attempt to resolve such an issue
  3. Please be kind here

Thanks for your understanding

@mattiaferrari02
Copy link

@frankcalise @flexbox apologies for my rudeness. To replicate the issue i followed these steps:

  • scaffold a new project using this PR
  • run prebuild
  • run build:ios:dev

When the app is building in eas an error occurs because of glog.
That's it
When i downgraded back to latest it started working, i used this PR because i thought that expo deprecated also sdk 49, but luckily it wasn't the case

@frankcalise
Copy link
Contributor Author

@mattiaferrari02 can you provide the output from the command npx ignite-cli@latest doctor please?

@frankcalise frankcalise merged commit ff8df47 into master Feb 9, 2024
1 check passed
@frankcalise frankcalise deleted the feat/expo-50 branch February 9, 2024 21:29
infinitered-circleci pushed a commit that referenced this pull request Feb 9, 2024
# [9.5.0](v9.4.6...v9.5.0) (2024-02-09)

### Features

* upgrade to Expo SDK 50 ([#2612](#2612) by [@frankcalise](https://github.com/frankcalise)) ([ff8df47](ff8df47))
@infinitered-circleci
Copy link

🎉 This PR is included in version 9.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants