-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support ~ in path with resolve-dir #238
Conversation
Sorry for the delay, can you see about updating the tests to pass? |
@GantMan Sorry for my delay. Everything should works. I can't see that tests on Semaphore CI work, but on Travis is occur a problem with running them. |
@piecioshka - please resolve the conflict and tests should pass. |
* master: fix custom error bug, add test, fix typo, refactor test (#257)
@GantMan Done. Do you know what happen on Travis? |
if you have that error, its because yarn has to update its lockfile, but --frozen-lockfile prevents it from doing so. A good idea on ci. The fix is simple - rerun yarn locally, and push the changes to the lockfile. Which makes sense here because the package.json was changed, and with no changes to yarn.lock |
@piecioshka - once this is merged, I'll release a new version. |
Codecov Report
@@ Coverage Diff @@
## master #238 +/- ##
==========================================
+ Coverage 83.49% 83.52% +0.02%
==========================================
Files 36 36
Lines 709 710 +1
Branches 139 139
==========================================
+ Hits 592 593 +1
Misses 75 75
Partials 42 42
Continue to review full report at Codecov.
|
Hi @GantMan! I updated yarn.lock file (what @tabrindle told). How can we resolve that issue? |
merged! |
No description provided.