Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Move x records outputed from smdk test to --verbose #3169

Closed
ajhunyady opened this issue Apr 19, 2023 · 5 comments
Closed

[Bug]: Move x records outputed from smdk test to --verbose #3169

ajhunyady opened this issue Apr 19, 2023 · 5 comments
Labels
good first issue Good for newcomers help wanted Good issue for community involvement
Milestone
0.10.9

Comments

@ajhunyady
Copy link
Contributor

ajhunyady commented Apr 19, 2023 •
edited
Loading

Since most of the use cases we are currently facing are json it is be useful to pipe the result of smdk test to jq.

But the x records outputed like breaks this functionality.

Add a new flag --verbose, to smdk test and move x records outputed under this flag:

smdk test ... --verbose
x records outputed
...
@ajhunyady ajhunyady added bug Something isn't working help wanted Good issue for community involvement good first issue Good for newcomers labels Apr 19, 2023
@sehz sehz removed the bug Something isn't working label Apr 19, 2023
@TanNgocDo
Copy link
Contributor

TanNgocDo commented May 6, 2023 •
edited
Loading

so, without "verbose" the output should be :

smdk test ...
record_1
record_2
.....

with verbose :

smdk test ... --verbose
x records outputed
record_1
record_2
.....

right? @ajhunyady ?

@ajhunyady
Copy link
Contributor Author

Hi @TanNgocDo, yes, the example provided looks right.
Thanks for looking into this.

@TanNgocDo TanNgocDo mentioned this issue May 7, 2023
Closed
@TanNgocDo
Copy link
Contributor

Thanks @ajhunyady , I have just made a simple PR

@ajhunyady
Copy link
Contributor Author

Thank you for the PR @TanNgocDo! The engineering team will review soon.

@sehz sehz linked a pull request May 9, 2023 that will close this issue
[Merged by Bors] - Move x records outputed from smdk test to --verbose #3169 #3234
Closed
@sehz sehz added this to the 0.10.9 milestone May 9, 2023
bors bot pushed a commit that referenced this issue May 9, 2023
@TanNgocDo
Move x records outputed from smdk test to --verbose #3169 (#3234)
da1cd2e 
This is to add verbose flag into smdk test : #3169
bors bot pushed a commit that referenced this issue May 9, 2023
@TanNgocDo
Move x records outputed from smdk test to --verbose #3169 (#3234)
8e95c79 
This is to add verbose flag into smdk test : #3169
@sehz
Copy link
Contributor

sehz commented May 12, 2023

done

@sehz sehz closed this as completed May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Good issue for community involvement
Projects
None yet
Milestone
0.10.9
Development

Successfully merging a pull request may close this issue.

[Merged by Bors] - Move x records outputed from smdk test to --verbose #3169 TanNgocDo/fluvio
3 participants
@sehz @TanNgocDo @ajhunyady