Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Move x records outputed from smdk test to --verbose #3169 #3234

Closed

Conversation

TanNgocDo
Copy link
Contributor

This is to add verbose flag into smdk test : #3169

Copy link
Contributor

@ajhunyady ajhunyady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please also add a test for the non-verbose case?

run $SMDK_BIN test --text '["foo", "bar"]'

@ajhunyady ajhunyady requested a review from morenol May 7, 2023 15:57
Add verbose smoke test
@TanNgocDo
Copy link
Contributor Author

TanNgocDo commented May 8, 2023

Can you please also add a test for the non-verbose case?

run $SMDK_BIN test --text '["foo", "bar"]'

Hi @ajhunyady , Sorry, I have not paid attention that smoke test fail. I Tried to reproduce in my local machine the smoke test(I'm using Mac M1) but it seems not work(or I'm doing a wrong way). Here is the way I tried to reproduce smoke test:

export SMDK_BIN=....
bats ./tests/cli/smdk_smoke_tests/smdk-basic.bats

All the test are failed because no config in my fluvio folder:

Error: Config error: config file "/Users/tando/.fluvio/config"
   
     Caused by:
         0: config file "/Users/tando/.fluvio/config"
         1: No such file or directory (os error 2)

I'm not sure how to create such config - I'm using Mac M1.
cc @morenol
ps: All wasm modules were created but it seems to be failed at loading:

  Found SmartModule package: repo-params-aggregate-zxoua3c
     loading module at: /private/var/folders/dw/54y7x1l51v1_wjrwz5dp5cfc0000gn/T/smdk-test.XXXXX.LXXDNS0n/target/wasm32-unknown-unknown/release-lto/repo_params_aggregate_zxoua3c.wasm
     Error: Config error: config file "/Users/tando/.fluvio/config"


```




refute_output without verbose
@TanNgocDo
Copy link
Contributor Author

Update : I think I should change the Generate and test filter-map

# Test
    run $SMDK_BIN test --verbose --text '2'
    assert_output --partial "1 records outputed"
    assert_output --partial "1" #changed from 2 -> 1 (Have tested in my local the generated wasm smart module)
    assert_success

Thanks

@ajhunyady
Copy link
Contributor

@morenol please review.

@sehz sehz added this to the 0.10.9 milestone May 8, 2023
Copy link
Contributor

@morenol morenol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

crates/smartmodule-development-kit/src/test.rs Outdated Show resolved Hide resolved
Co-authored-by: morenol <22335041+morenol@users.noreply.github.com>
@morenol morenol requested a review from sehz May 8, 2023 17:18
Copy link
Contributor

@sehz sehz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. couple of minor nits

crates/smartmodule-development-kit/src/main.rs Outdated Show resolved Hide resolved
minor change debug format
Copy link
Contributor

@sehz sehz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sehz sehz linked an issue May 9, 2023 that may be closed by this pull request
@sehz
Copy link
Contributor

sehz commented May 9, 2023

bors r+

bors bot pushed a commit that referenced this pull request May 9, 2023
This is to add verbose flag into smdk test : #3169
@bors
Copy link

bors bot commented May 9, 2023

Build failed:

@sehz
Copy link
Contributor

sehz commented May 9, 2023

bors retry

bors bot pushed a commit that referenced this pull request May 9, 2023
This is to add verbose flag into smdk test : #3169
@bors
Copy link

bors bot commented May 9, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title Move x records outputed from smdk test to --verbose #3169 [Merged by Bors] - Move x records outputed from smdk test to --verbose #3169 May 9, 2023
@bors bors bot closed this May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Move x records outputed from smdk test to --verbose
4 participants