-
Notifications
You must be signed in to change notification settings - Fork 495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Move x records outputed from smdk test to --verbose #3169 #3234
[Merged by Bors] - Move x records outputed from smdk test to --verbose #3169 #3234
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please also add a test for the non-verbose
case?
run $SMDK_BIN test --text '["foo", "bar"]'
Add verbose smoke test
Hi @ajhunyady , Sorry, I have not paid attention that smoke test fail. I Tried to reproduce in my local machine the smoke test(I'm using Mac M1) but it seems not work(or I'm doing a wrong way). Here is the way I tried to reproduce smoke test:
All the test are failed because no config in my fluvio folder:
I'm not sure how to create such config - I'm using Mac M1.
|
refute_output without verbose
Update : I think I should change the Generate and test filter-map
Thanks |
@morenol please review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: morenol <22335041+morenol@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. couple of minor nits
minor change debug format
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
bors r+ |
Build failed: |
bors retry |
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
This is to add verbose flag into smdk test : #3169