Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update Static Legend interface #566

Merged
merged 2 commits into from
May 4, 2021
Merged

feat: update Static Legend interface #566

merged 2 commits into from
May 4, 2021

Conversation

TCL735
Copy link
Contributor

@TCL735 TCL735 commented May 4, 2021 •
edited
Loading

In support of influxdata/ui#806

  • A consuming app may need to adjust margin and padding around the Static Legend Box, allow this.
  • Other styles can be added without further interface changes.
  • Does not affect commonly-used strategically-important styles previously defined in the interface.

@TCL735 TCL735 force-pushed the feat_ui_806_update_static_legend_config branch from 4d493c9 to 45d31ba Compare May 4, 2021 03:22
@TCL735 TCL735 requested a review from zoesteinkamp May 4, 2021 22:33
hoorayimhelping
hoorayimhelping approved these changes May 4, 2021
View reviewed changes
Copy link
Contributor

@hoorayimhelping hoorayimhelping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you need to bump package.json?

@TCL735
Copy link
Contributor Author

TCL735 commented May 4, 2021

do you need to bump package.json?

Not yet. I still need the Scrollbars option and the code for Band Plot.

@TCL735 TCL735 merged commit a040701 into master May 4, 2021
@TCL735 TCL735 deleted the feat_ui_806_update_static_legend_config branch May 4, 2021 23:35
@TCL735 TCL735 mentioned this pull request May 7, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoorayimhelping hoorayimhelping hoorayimhelping approved these changes

@jrenee42 jrenee42 Awaiting requested review from jrenee42

@zoesteinkamp zoesteinkamp Awaiting requested review from zoesteinkamp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TCL735 @hoorayimhelping