tags with value 0 or False not pushed to InfluxDB

[michelfripiat]

When I want to push tags with value equaling to 0 or False, the tag is not accepted.
After investigation, the line to blame is here:

influxdb-python/influxdb/_dataframe_client.py

Line 374 in 3d61f1f

[",{}={}".format(k, _escape_tag(v)) if v else ''

I patched it and here is how I solved it:
Before:
tag_string = ''.join( [",{}={}".format(k, _escape_tag(v)) if v else '' for k, v in sorted(global_tags.items())] )
After:
tag_string = ''.join( [",{}={}".format(k, _escape_tag(v)) if v not in [None, ''] else '' for k, v in sorted(global_tags.items())] )

Furthermore, it would be nice to also send a tags even if the value is None. Here is my proposition:
tag_string = ''.join( [",{}={}".format(k, _escape_tag(v)) if v not in [None, ''] else ",{}={}".format(k, 'None') for k, v in sorted(global_tags.items())] )

[russorat]

@michelfripiat thank you for the issue. Is this something you would consider contributing to the project?

[michelfripiat]

For sure, what does that imply?

[russorat]

@michelfripiat all you need to do is open a pull request with the change you'd identified and someone will take a look.

[sebito91]

Closed by #770