This repository was archived by the owner on Oct 29, 2024. It is now read-only.
fix: resolving raising exception when calling the commit function without any SeriesHelper #771
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es raising exception because _datapoints is None. It is hard to find the reason of this error. it is because reviewing influxdb-python's code is needed. So, I've fixed that if _datapoints is None in the commit function, _datapoints is set to defaultdict to avoid raising error.
|
I'll request this pull request again with small changes. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If any SeriesHelper is not generated, calling the commit function makes raising exception because _datapoints is None.
It is hard to find the reason of this error. it is because reviewing influxdb-python's code is needed.
So, I've fixed that if _datapoints is None in the commit function, _datapoints is set to defaultdict to avoid raising error.
Contributor checklist
=> it is not feature addition but covering an exception.