Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to delete a template #12888

Merged
merged 1 commit into from
Mar 26, 2019
Merged

Add the ability to delete a template #12888

merged 1 commit into from
Mar 26, 2019

Conversation

Palakp41
Copy link
Contributor

@Palakp41 Palakp41 commented Mar 26, 2019

Co-authored-by: Alirie Gray alirie.gray@gmail.com

Closes #12742

Briefly describe your proposed changes:
Updated the client to match the swagger's definition of delete template
Updated template card to call Delete action
Created actions and reducers to update the redux state to remove the template

  • CHANGELOG.md updated with a link to the PR (not the Issue)
  • Rebased/mergeable
  • Tests pass

@Palakp41 Palakp41 force-pushed the feat/templates-delete branch 2 times, most recently from 6bf0da4 to 5f3ca1e Compare March 26, 2019 00:09
Copy link
Contributor

@ebb-tide ebb-tide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

ui/src/templates/reducers/index.ts Outdated Show resolved Hide resolved
Co-authored-by: Alirie Gray <alirie.gray@gmail.com>
@Palakp41 Palakp41 merged commit 6c6247e into master Mar 26, 2019
@Palakp41 Palakp41 deleted the feat/templates-delete branch March 26, 2019 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants