Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed task manual run notification type #14412

Merged
merged 3 commits into from
Jul 23, 2019
Merged

Fixed task manual run notification type #14412

merged 3 commits into from
Jul 23, 2019

Conversation

russorat
Copy link
Contributor

@russorat russorat commented Jul 22, 2019 •
edited
Loading

Closes #

Describe your proposed changes here.
The notification types on the manual run task were swapped. this fixes that.

  • CHANGELOG.md updated with a link to the PR (not the Issue)
  • Well-formatted commit messages
  • Rebased/mergeable
  • Tests pass
  • http/swagger.yml updated (if modified Go structs or API)
  • Documentation updated or issue created (provide link to issue/pr)
  • Signed CLA (if not already signed)

@russorat russorat requested a review from Palakp41 July 22, 2019 23:25
ebb-tide
ebb-tide approved these changes Jul 22, 2019
View reviewed changes
Copy link
Contributor

@ebb-tide ebb-tide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍰 🍰 🍰

@russorat russorat removed the request for review from Palakp41 July 22, 2019 23:27
Palakp41
Palakp41 approved these changes Jul 22, 2019
View reviewed changes
Copy link
Contributor

@Palakp41 Palakp41 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

goller
goller approved these changes Jul 22, 2019
View reviewed changes
Copy link
Contributor

@goller goller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @russorat

@russorat russorat merged commit 3dafbc6 into master Jul 23, 2019
@russorat russorat deleted the fix-task-notification branch July 23, 2019 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Palakp41 Palakp41 Palakp41 approved these changes

@ebb-tide ebb-tide ebb-tide approved these changes

@goller goller goller approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@russorat @goller @ebb-tide @Palakp41