Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed task manual run notification type #14412

Merged
merged 3 commits into from
Jul 23, 2019
Merged

Fixed task manual run notification type #14412

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b7e39ed
Fixed task manual run notification type
Jul 22, 2019
e7e80b0
updating changelog
Jul 22, 2019
0502b1f
fixing trailing whitespace in stale.yml config
Jul 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/stale.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,5 +17,5 @@ markComment: >
# Comment to post when closing a stale issue. Set to `false` to disable
closeComment: >
This issue has been automatically closed because it has not had
recent activity. Please reopen if this issue is still
recent activity. Please reopen if this issue is still
important to you. Thank you for your contributions.
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
### Bug Fixes

1. [14287](https://github.com/influxdata/influxdb/pull/14287) Fix incorrect reporting of task as successful when error occurs during result iteration
1. [14412](https://github.com/influxdata/influxdb/pull/14412) Fix incorrect notification type for manually running a Task

### Known Issues

Expand Down
4 changes: 2 additions & 2 deletions ui/src/shared/copy/notifications.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -500,13 +500,13 @@ export const taskImportSuccess = (): Notification => ({
})

export const taskRunSuccess = (): Notification => ({
...defaultErrorNotification,
...defaultSuccessNotification,
duration: FIVE_SECONDS,
message: 'Task scheduled successfully',
})

export const taskRunFailed = (error: string): Notification => ({
...defaultSuccessNotification,
...defaultErrorNotification,
duration: FIVE_SECONDS,
message: `Failed to run task: ${error}`,
})
Expand Down