Bugfix/21065 #21066
Closed
Bugfix/21065 #21066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add test case for influxdata#9522
…ld-on-delete-when-series-still-in-cache No rebuild series index on delete when the series still exists in cache
…snapshots Fix compaction logic on infrequent cache snapshots
…est.go to reflect changes
Scanner objects and iterators often need a ValuerEval. This object is created, often with a function call, and has at least one interface in it, so it allocates storage. Then it's dropped again right away. The only part of it that might be subject to change is usually a map. While the map's contents change over time, the actual map doesn't change for the lifetime of the object. So, in both iterators and scanners, stash the ValuerEval and continue reusing it. On a query returning a fair number of data points, this produces a small (<5% in practice) improvement in observed performance, visible as a significant reduction in time spent in runtime (mallocgc, newobject, etcetera). The performance improvement isn't big, but it's reasonably easy to evaluate it and establish that it's a safe change to make. Signed-off-by: seebs <seebs@seebs.net>
reuse ValuerEval objects
Use Systemd for Amazon Linux 2
…er-reference [BUG FIX] Fix nil pointer dereference at /api/v1/prom/read
Fix legacy restore bug influxdata#10072
Simplify s[:] to s where s is a slice
Modify context key type
This reverts commit 40db64d.
…ull-compaction-1.8 Revert "Limit force-full and cold compaction size."
This commit changes `name`, `key`, and `value` to from `[]byte` to `string`.
…ng-1.8 Convert TagValueSeriesIDCache to use string fields.
chore: update changelog
This commit changes the SeriesIDSet merge/union/intersect functions to attach the underlying iterators as closers so that files can be retained until the data is no longer in use. The roaring operations can leave containers pointing at mmap data in the resulting bitmap so we have to track underlying file usage until the data is finished with.
…-iterator-merge-retention-1.8 fix(tsdb): Defer closing of underlying SeriesIDSetIterators
This commit changes `DefaultSeriesIDSetCacheSize` to zero so that the tag value cache is disabled by default. There is a rare known bug where the cache can cause a segfault which crasheds the process. The cache is being disabled instead of removed as some users may still need the cache for performance reasons.
…-series-id-cache-1.8 fix(tsdb): Disable series id set cache size by default.
) Have AuthorizerIsOpen() assert if a given authizer has an AuthorizeUnrestricted() method and if so, call that to provide the result of AuthorizerIsOpen(). Otherwise we check if the supplied Authorizer is nil. This preserves the fast-path for checking tag-level (and other) tsdb operations. This simplifies how we handle such authorizers by handling this case in only one place.
…eld-iterator-planning-1.8 feat(query): Parallelize field iterator planning
…ropping-shard-1.8 fix(tsi1): wait deleting epoch before dropping shard
…tones-when-deleting-1.8 perf(tsi1): batch write tombstone entries when dropping/deleting
The buckets call had a column removed and the backport did not remove that line. This modifies the buckets command to not append a row to a column that no longer exists.
When applied this patch will: * log snapshot directory removal errors Prior to this patch, errors when removing temporary snapshot directories happens silently. This patch ensures that errors are logged when os.RemoveAll() fails. * refactor tsm1: Declare error value in condition Save a line of code and limits the scope of an error value. * refactor tsm1: Add MakeSnapshotLinks() This commit adds (*FileStore).MakeSnapshotLinks(). The code in this function was originally part of CreateSnapshot(). That code was hoisted out and into MakeSnapshotLinks() becuase there are two points of failure that require cleanup -- we have to delete a temporary directory on failure. Placing the code in one function allows us to check its returned error value and perform cleanup in only once place. In short, we hoisted code out of CreateSnapshot() to simplify error handling. On error, we remove any directories we created.
…e-errors-bp1.8 fix: gracefully handle errors when creating snapshots
This patch adds the [http.headers] subsection to the configuration file that allows users to supply headers that will be returned in all HTTP responses. Applying this patch will: * Add code to implement new configuration items. * Add test to ensure configuration is properly parsed. * Add test to ensure http response headers are set * Update sample configuration file
…ttp-headers-bp1.8 feat(http): Allow user supplied HTTP headers
This reverts commit 9c41e12.
…-series-id-set-cache-size-1.8 fix(tsdb): Revert disable series id set cache size by default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #21065
Describe your proposed changes here.
If there is an error in creating an
Iterator, theinputreturn bysg.CreateIterator(ctx, mm, opt)will be nil.however, when close the
Iterator, There is no operation to check the status, so there is a panic forclose()