feat: enable notebooks and annotations #21972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williamhbaker
commented
Jul 29, 2021
| @@ -94,22 +74,6 @@ | |||
| default: false | |||
| expose: true | |||
|
|
|||
| - name: UI CSV Uploader | |||
There was a problem hiding this comment.
Removed from the UI in influxdata/ui#1130
| expose: true | ||
| lifetime: temporary | ||
|
|
||
| - name: Editable Telegraf Configurations |
There was a problem hiding this comment.
Removed from the UI in influxdata/ui#1597
| # not if the notebooks button is enabled on the sidebar. The notebooks flag (above) controls | ||
| # the display of the notebooks button on the sidebar. The notebooksAPI flag should be set to true | ||
| # to ensure the UI sends requests that the OSS backend can handle. | ||
| - name: Notebooks Service API |
There was a problem hiding this comment.
Removed from the UI in influxdata/ui#1809
| @@ -55,26 +55,6 @@ | |||
| contact: Query Team | |||
| lifetime: permanent | |||
|
|
|||
| - name: Notebooks | |||
There was a problem hiding this comment.
Removed from the UI in influxdata/ui#1995
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #21217
Closes #21266
This PR enables notebooks and annotations by removing the feature flag for
notebooksandnotebooksApi, both of which are no longer checked for in the UI (they are always on in the latest UI), and turns the feature flag forannotationsto betrueby default.I also cleaned up a few other UI-related feature flags that have been removed from the UI