Allow PointerWriter timeout to be configurable #3218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otoolep
force-pushed
the
config_timeouts
branch
2 times, most recently
from
286215f
to
a24e287
Compare
|
Looking into test failures. |
|
Green build, was missing a required change to the tests. |
|
+1 |
| @@ -48,7 +48,8 @@ reporting-disabled = false | |||
| ### | |||
|
|
|||
| [cluster] | |||
| shard-writer-timeout = "5s" | |||
| shard-writer-timeout = "5s" # The time within which a shard must respond to write. | |||
There was a problem hiding this comment.
is this for a local shard? If so it seems this should be in the data section and not cluster
otoolep
added a commit
that referenced
this pull request
Jul 2, 2015
Allow PointerWriter timeout to be configurable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes the time the system will wait for the write to complete, across the cluster, configurable. Previously this was hardcoded to 5 seconds