Start with influxdb-rust crate #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty2k12
commented
May 31, 2019
msrd0
requested changes
May 31, 2019
| .into_iter() | ||
| .map(|(field, value)| format!("{field}={value}", field = field, value = value)) | ||
| .collect::<Vec<String>>() | ||
| .join(","); |
There was a problem hiding this comment.
Same here, remove the collect
|
|
||
| impl InfluxDbClient { | ||
| pub fn ping(&self) -> impl Future<Item = (String, String), Error = ()> { | ||
| Client::new() |
There was a problem hiding this comment.
Why are you creating a new Client everytime?
There was a problem hiding this comment.
How would you solve this?
There was a problem hiding this comment.
Well, generally I prefer to have the Client be stored in a variable of the associated type and give the user a way to specify their own Client if they prefer. This might also be helpful when trying to mock http calls
| } | ||
|
|
||
| // fixme: double space | ||
| // fixme: quoting / escaping of long strings |
There was a problem hiding this comment.
Don't add fixme in tests. If the code doesn't do what you want, the test should fail. That's the whole idea about testing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.