Skip to content

Prefix InfluxDb of type names are redundant #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 10, 2019
Merged

Prefix InfluxDb of type names are redundant #27

merged 4 commits into from
Oct 10, 2019

Conversation

Empty2k12
Copy link
Collaborator

@Empty2k12 Empty2k12 commented Oct 9, 2019 •
edited
Loading

Fixes #25, fixes #8

@pcpthm Review would be appreciated!

@Empty2k12 Empty2k12 added this to the Release 0.0.5 milestone Oct 9, 2019
This was referenced Oct 9, 2019
Closed
Closed
@Empty2k12 Empty2k12 force-pushed the feature/25-prefix-influxdb-of-type-names-are-redundant branch from 0521855 to b8a5dc7 Compare October 9, 2019 21:06
pcpthm
pcpthm approved these changes Oct 10, 2019
View reviewed changes
Copy link
Contributor

@pcpthm pcpthm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@Empty2k12 Empty2k12 merged commit 4f1d4f6 into master Oct 10, 2019
@Empty2k12 Empty2k12 deleted the feature/25-prefix-influxdb-of-type-names-are-redundant branch October 10, 2019 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@pcpthm pcpthm pcpthm approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Type: Enhancement Type of Change: Medium
Projects
None yet
Milestone
Release 0.0.5
Development

Successfully merging this pull request may close these issues.

Prefix InfluxDb of type names are redundant Reexport Classes and Structs under a sane import path (e.g. influxdb::)
2 participants
@Empty2k12 @pcpthm