Skip to content

Replace ToString with Into<String> #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 11, 2019
Merged

Replace ToString with Into<String> #30

merged 4 commits into from
Oct 11, 2019

Conversation

Empty2k12
Copy link
Collaborator

@Empty2k12 Empty2k12 commented Oct 11, 2019 •
edited
Loading

Fixes #24

@Empty2k12 Empty2k12 added this to the Release 0.0.5 milestone Oct 11, 2019
msrd0
msrd0 requested changes Oct 11, 2019
View reviewed changes
Copy link
Collaborator

@msrd0 msrd0 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(unfortunately GitHub is incompetent)

msrd0
msrd0 requested changes Oct 11, 2019
View reviewed changes
msrd0
msrd0 requested changes Oct 11, 2019
View reviewed changes
@Empty2k12 Empty2k12 added the Status: Merge when CI passes This PR has been reviewed and accepted for merge label Oct 11, 2019
@Empty2k12 Empty2k12 merged commit 9f29439 into master Oct 11, 2019
@Empty2k12 Empty2k12 deleted the feature/24-consider-replacing-tostring-bound-for-more-precise-bound branch October 11, 2019 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msrd0 msrd0 msrd0 approved these changes

Assignees
No one assigned
Labels
Status: Merge when CI passes This PR has been reviewed and accepted for merge Type: Enhancement Type of Change: Minor
Projects
None yet
Milestone
Release 0.0.5
Development

Successfully merging this pull request may close these issues.

Consider replacing ToString bound for more precise bound
2 participants
@Empty2k12 @msrd0