Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deserialization of Series in case of no values. #75

Merged
merged 1 commit into from
Nov 17, 2020
Merged

Fix deserialization of Series in case of no values. #75

merged 1 commit into from
Nov 17, 2020

Conversation

JEnoch
Copy link
Contributor

@JEnoch JEnoch commented Nov 17, 2020

Description

Fix deserialization of Series in case of no values. Fix #74

Checklist

  • Formatted code using cargo fmt --all
  • Linted code using clippy cargo clippy --all-targets --all-features -- -D warnings
  • Updated README.md using cargo readme -r influxdb -t ../README.tpl > README.md
  • Reviewed the diff. Did you leave any print statements or unnecessary comments?
  • Any unfinished work that warrants a separate issue captured in an issue with a TODO code comment

@Empty2k12
Copy link
Collaborator

Hey. Thanks for this code change.

Seems like you're running into a lot of edge-cases that have not been found yet. I am very grateful for your help in fixing those and would like to apologize for this.

Merging now!

@Empty2k12 Empty2k12 changed the title Fix deserialization of Series in case of no values. Fix #74 Fix deserialization of Series in case of no values. Nov 17, 2020
@Empty2k12 Empty2k12 merged commit 9cd527a into influxdb-rs:master Nov 17, 2020
@Empty2k12
Copy link
Collaborator

I am not sure when I will be able to release this. Would you be comfortable using the Git version for now until we're sure that there are no other problems you're running into that should make it into a release?

@JEnoch
Copy link
Contributor Author

JEnoch commented Nov 17, 2020

Sure, that's what I just did here: eclipse-zenoh/zenoh@00e23a7 .
I'm done with the integration of InfluxDB into zenoh for now, so I probably won't find new issues in the next weeks.
But zenoh users might... 😉
Anyhow, we won't need for a new influxdb-rust release before our final 0.5.0 release, which won't happen before end of 2020.

@Empty2k12
Copy link
Collaborator

Hello! I just published a change to crates.io containing your change as version 0.4.0. Thanks again for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DeserializationError on "SHOW DATABASES" using non-admin credentials
2 participants