Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batch write support #87

Merged
merged 6 commits into from
Mar 6, 2021
Merged

Conversation

sunng87
Copy link
Contributor

@sunng87 sunng87 commented Mar 5, 2021

Description

This patch adds supports for write query in batch, which is originally supported from influxdb line protocol. I also removed QueryTypes enum because it duplicates with QueryType

Fixes #86

Checklist

  • Formatted code using cargo fmt --all
  • Linted code using clippy cargo clippy --all-targets --all-features -- -D warnings
  • Updated README.md using cargo readme -r influxdb -t ../README.tpl > README.md
  • Reviewed the diff. Did you leave any print statements or unnecessary comments?
  • Any unfinished work that warrants a separate issue captured in an issue with a TODO code comment

@sunng87
Copy link
Contributor Author

sunng87 commented Mar 5, 2021

Those lint errors are not related with this changeset so I'm not fixing it in this PR. I can open another PR if needed.

I've got them fixed.

@sunng87 sunng87 marked this pull request as ready for review March 6, 2021 12:52
@Empty2k12
Copy link
Collaborator

Looks good! Thanks a lot @sunng87 🚀

@Empty2k12 Empty2k12 merged commit 1950876 into influxdb-rs:master Mar 6, 2021
@sunng87 sunng87 deleted the feature/batch-write branch March 7, 2021 02:54
@sunng87
Copy link
Contributor Author

sunng87 commented Mar 7, 2021

@Empty2k12 Thank you for quick response. Could you please make a release for this?

@Empty2k12
Copy link
Collaborator

Hello! I just published a change to crates.io containing your change as version 0.4.0. Thanks again for your contribution!

@sunng87
Copy link
Contributor Author

sunng87 commented Mar 9, 2021

Thank you!

sdether added a commit to sdether/influxdb-rust that referenced this pull request Jun 15, 2022
sdether added a commit to sdether/influxdb-rust that referenced this pull request Jun 15, 2022
sdether added a commit to sdether/influxdb-rust that referenced this pull request Jun 15, 2022
sdether added a commit to sdether/influxdb-rust that referenced this pull request Jun 15, 2022
sdether added a commit to sdether/influxdb-rust that referenced this pull request Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Batching support for WriteQuery
2 participants