Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release maintenance 101 #27

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

mpasternak
Copy link
Contributor

Hi,

  • support "bumpversion" so you can release new versions easily (pip install bumpversion; bumpversion patch; git push --tags)

  • support universal wheel target in setup.cfg

  • release target for makefile so you can easily release sdist + wheel at once

credits go to @pydanny and @audreyr for creating cookiecutter-pypackage.

@jascoul
Copy link
Collaborator

jascoul commented Jul 7, 2017

Hi, thanks so much. I don't have time right now to look into it, sorry.
It will be the end of next week before I can do an update.

@interrogator
Copy link

Could this include bump2version in setup.py (with version locks) and/or currently non-existent requirements.txt (which would also need to have lxml and six, ideally version locked? It's kind of a dev-only dependency but it's tiny and I think it's a really nice way to manage releases...

Also in an ideal world I think you would add version to src/pyoai/__init__.py with a line like:

__version__ = "x.x.x"

You then add this file to the bumpversion config so that it is updated correctly when you run the bumpverion command, and also, having this here means you can import this variable for use elsewhere. And you can do import pyoai; pyoai.__version__ to see what's current installed. As far as I know, that's the standard way of doing this at the moment.

I'd volunteer to do this if it @mpasternak doesn't have time, and if you guys actually agree to start merging these maintenance PRs :)

@mpasternak
Copy link
Contributor Author

@interrogator I'm here, but feel free to do that. I really do hope other @infrae guys get their stuff together and start merging PRs. Let me know how it went.

@wetneb
Copy link
Collaborator

wetneb commented Apr 26, 2020

Although I technically have the permissions to merge PRs I will not merge any PR as long as Travis does not checks PRs, and I cannot enable that.

@interrogator
Copy link

So we wait on @jascoul 🐈

@jascoul
Copy link
Collaborator

jascoul commented Apr 28, 2020

@wetneb what is needed for Travis to build PRs? Is it just a change in the .travis.yml?

I feed bad for the project being on hold because of a lack of time on my part.
I would like to have the whole release maintenance sorted out. If you are willing to take the responsibility, I will also add you to Pypi so you can do new releases.

@wetneb
Copy link
Collaborator

wetneb commented Apr 28, 2020

@jascoul the .travis.yml is fine, it is the Travis integration in GitHub. One easy way to fix it would be to disable the Travis integration entirely in the GitHub project settings, and add it again from Travis. This would set up the integration correctly.

@jascoul
Copy link
Collaborator

jascoul commented Apr 28, 2020

@wetneb I removed Travis as an authorized app, is that what you meant?

@wetneb
Copy link
Collaborator

wetneb commented Apr 28, 2020

Yes, and now you should be able to add it back from travis-ci.org.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants