Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow the connector to run outside of a kube pod #2613

Merged
merged 3 commits into from
Oct 3, 2022
Merged

Allow the connector to run outside of a kube pod #2613

merged 3 commits into from
Oct 3, 2022

Commits on Oct 3, 2022

  1. improve: reduce the number of places we look up values from in-cluster 

    Previously we would only look for in-cluster config. In the future we
should be able to specify these values from config options, so that we
can run a connector in tests.

This change reduces the number of places we use the in-cluser calls by
relying on the rest.Config that is populated by the NewKubernetes
constructor.

Also read the CA cert from the existing config, instead of reading the
file again.

Also remove the SecretReader field, it was never used.

Also add more godoc.
    @dnephin
    dnephin committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    30a38cf View commit details
    Browse the repository at this point in the history

  2. maintain: extract type for args 

    This should allow us to split up the conection logic by using this
new type as the function parameter.
    @dnephin
    dnephin committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    ec245ac View commit details
    Browse the repository at this point in the history

  3. maintain: extract syncDestination from syncWithServer

    @dnephin
    dnephin committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    622366f View commit details
    Browse the repository at this point in the history