Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for readme example how to verify notifications #17

Closed
wants to merge 2 commits into from
Closed

Fix for readme example how to verify notifications #17

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
62d2f07
Fix for readme example how to verify notifications
t-soltysiak Jun 30, 2024
142f040
added some not in readme about rawBody req.
t-soltysiak Jul 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ const headers = req.headers;

const isValid = payU.verifyNotification(
headers["OpenPayu-Signature"],
JSON.stringify(req.body)
req.body
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think in express we gotta use req.rawBody with row-body-parser

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we gotta add a comment about this

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, I added some note about what need to be passed into rawBody, IMHO information that is framework specific is more universal than giving specific examples...

);

console.log(isValid);
Expand Down