Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support PHP 8.1 & PHP 8.2 #41

Merged
merged 20 commits into from
Oct 14, 2022
Merged

Support PHP 8.1 & PHP 8.2 #41

merged 20 commits into from
Oct 14, 2022

Conversation

craig410
Copy link
Member

No description provided.

@craig410
Copy link
Member Author

craig410 commented Oct 14, 2022

@acoulton it's taking shape, smaller changeset than I imagined. WDYT? I know it's failing on the lowest dependency builds. Haven't looked at it properly yet, appears to be some kohana autoloader related thing not finding classes PHPUnit 9.5 below 9.5.22 breaks loading PSR-0 classes

Copy link
Member

@acoulton acoulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great.

classes/Kohana/Arr.php Outdated Show resolved Hide resolved
classes/Kohana/Valid.php Show resolved Hide resolved
Base automatically changed from reformat-test-code to 4.x October 14, 2022 11:07
@craig410
Copy link
Member Author

@acoulton Release this as 4.8.7 or 4.9.0?

@craig410 craig410 changed the title Support PHP 8.1 Support PHP 8.1 & PHP 8.2 Oct 14, 2022
@craig410 craig410 merged commit 9f5d8e4 into 4.x Oct 14, 2022
@craig410 craig410 deleted the support-php81 branch October 14, 2022 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants