fix: MysqlSession should validate session ID format before checking DB #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acoulton
force-pushed
the
2.x-bug-validate-session-id
branch
from
a9665ac to
0ef4bbe
Compare
Credential-stuffing and malware bots will commonly attempt requests with manufactured session cookies e.g. to search for SQL, path or URL injection vulnerabilities. Currently, the MysqlSession driver checks all provided session IDs against the database to validate them. This is *NOT* a security issue, since we are using PDO's parameters to properly escape the provided values. However, it does cause an exception (and therefore an error report) because the `GET_LOCK` query uses the user-provided session ID as part of the lock name. If the lock name contains characters that are not valid in a lock, MySQL will give a syntax error, which in turn causes a PDOException. Instead, skip the database lookup and return false immediately (as for any other invalid session ID) if the ID does not match the expected length and character set.
acoulton
force-pushed
the
2.x-bug-validate-session-id
branch
from
0ef4bbe to
0863c13
Compare
craig410
approved these changes
Sep 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Credential-stuffing and malware bots will commonly attempt requests with manufactured session cookies e.g. to search for SQL, path or URL injection vulnerabilities.
Currently, the MysqlSession driver checks all provided session IDs against the database to validate them. This is NOT a security issue, since we are using PDO's parameters to properly escape the provided values.
However, it does cause an exception (and therefore an error report) because the
GET_LOCKquery uses the user-provided session ID as part of the lock name. If the lock name contains characters that are not valid in a lock, MySQL will give a syntax error, which in turn causes a PDOException.Instead, skip the database lookup and return false immediately (as for any other invalid session ID) if the ID does not match the expected length and character set.