creation error on empty dummy path

[sarnold]

This was just an initial manual test in venv before I move on to making some pytest fixtures BUT I keep getting an error trying to create some repos. Note the testdata path is completely empty:

$ git_dummy_git_dir=tests/testdata git-dummy --name=daffy --branches=4 --diverge-at=2
git-dummy error: Git repository already exists at tests/testdata/daffy or parent

The only way I could make it work here was to remove the whole try/except block before the call to git.Repo.init and then it seems to work fine.

My env:

Portage 3.0.49 (python 3.11.4-final-0, default/linux/arm64/17.0/desktop/gnome, gcc-12, glibc-2.37-r3, 6.3.10-x13s-r1 aarch64)
=================================================================
System uname: Linux-6.3.10-x13s-r1-aarch64-with-glibc2.37
KiB Mem:    15725124 total,   1147532 free
KiB Swap:    2097148 total,   1498876 free

$ tox -e py -r
py: remove tox env folder /home/user/src/repolite/.tox/py
py: install_deps> python -I -m pip install git-dummy 'pip>=21.1' 'setuptools_scm[toml]' '.[cov,test]'
py: commands[0]> python -m pytest -v tests/ --capture=no --cov=repolite --cov-branch --cov-report term-missing
============================= test session starts ==============================
platform linux -- Python 3.11.4, pytest-7.4.2, pluggy-1.3.0 -- /home/user/src/repolite/.tox/py/bin/python
cachedir: .tox/py/.pytest_cache
rootdir: /home/user/src/repolite
configfile: pyproject.toml
plugins: cov-4.1.0
collected 5 items                                                              

(py) $ python -m pip install -U git_dummy
Requirement already satisfied: git_dummy in ./.tox/py/lib/python3.11/site-packages (0.0.5)
Collecting git_dummy
  Obtaining dependency information for git_dummy from https://files.pythonhosted.org/packages/34/52/6d4132f441cc748a2c12f71d6befe4541252058e3a6564611ea793830b38/git_dummy-0.1.0-py3-none-any.whl.metadata
  Using cached git_dummy-0.1.0-py3-none-any.whl.metadata (5.9 kB)
Requirement already satisfied: gitpython in ./.tox/py/lib/python3.11/site-packages (from git_dummy) (3.1.35)
Requirement already satisfied: typer in ./.tox/py/lib/python3.11/site-packages (from git_dummy) (0.9.0)
Requirement already satisfied: pydantic-settings in ./.tox/py/lib/python3.11/site-packages (from git_dummy) (2.0.3)
Requirement already satisfied: gitdb<5,>=4.0.1 in ./.tox/py/lib/python3.11/site-packages (from gitpython->git_dummy) (4.0.10)
Requirement already satisfied: pydantic>=2.0.1 in ./.tox/py/lib/python3.11/site-packages (from pydantic-settings->git_dummy) (2.3.0)
Requirement already satisfied: python-dotenv>=0.21.0 in ./.tox/py/lib/python3.11/site-packages (from pydantic-settings->git_dummy) (1.0.0)
Requirement already satisfied: click<9.0.0,>=7.1.1 in ./.tox/py/lib/python3.11/site-packages (from typer->git_dummy) (8.1.7)
Requirement already satisfied: typing-extensions>=3.7.4.3 in ./.tox/py/lib/python3.11/site-packages (from typer->git_dummy) (4.7.1)
Requirement already satisfied: smmap<6,>=3.0.1 in ./.tox/py/lib/python3.11/site-packages (from gitdb<5,>=4.0.1->gitpython->git_dummy) (5.0.0)
Requirement already satisfied: annotated-types>=0.4.0 in ./.tox/py/lib/python3.11/site-packages (from pydantic>=2.0.1->pydantic-settings->git_dummy) (0.5.0)
Requirement already satisfied: pydantic-core==2.6.3 in ./.tox/py/lib/python3.11/site-packages (from pydantic>=2.0.1->pydantic-settings->git_dummy) (2.6.3)
Using cached git_dummy-0.1.0-py3-none-any.whl (12 kB)
Installing collected packages: git_dummy
  Attempting uninstall: git_dummy
    Found existing installation: git-dummy 0.0.5
    Uninstalling git-dummy-0.0.5:
      Successfully uninstalled git-dummy-0.0.5
Successfully installed git_dummy-0.1.0

[sarnold]

So I looked a little deeper at the code and this appears to be happening because I'm running git_dummy in the root of another project (ie, a git checkout). AFAICT from your docs, this should be allowed, no?

[initialcommit-io]

As discussed in #4, I refactored the code to disallow nested dummy repos by default, but added the --allow-nested flag to permit nested dummy repos within existing Git repos.

Please upgrade to version 0.1.2 to use this feature via pip install git-dummy --upgrade.

I'll leave this open so you can test it out and confirm that it works. Please let me know if you run into any issues.

[initialcommit-io]

@sarnold Did this work for you?

[initialcommit-io]

Closing since we added an enhancement that should resolve this per above. If any issues feel free to reopen!