Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve jump compensation with shift #409

Merged
merged 1 commit into from
Mar 13, 2024
Merged

Conversation

inokawa
Copy link
Owner

@inokawa inokawa commented Mar 12, 2024

#315

also fixes regression by #407

@inokawa inokawa force-pushed the improve-shift-stick-bottom branch 2 times, most recently from 660821c to 1f67cf0 Compare March 12, 2024 13:47
@inokawa inokawa marked this pull request as ready for review March 12, 2024 13:59
@inokawa inokawa merged commit b759f27 into main Mar 13, 2024
4 checks passed
@inokawa inokawa deleted the improve-shift-stick-bottom branch March 13, 2024 00:56
takecchi referenced this pull request in cuculus-dev/cuculus Mar 18, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [virtua](https://togithub.com/inokawa/virtua) | [`0.28.0` ->
`0.29.0`](https://renovatebot.com/diffs/npm/virtua/0.28.0/0.29.0) |
[![age](https://developer.mend.io/api/mc/badges/age/npm/virtua/0.29.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/virtua/0.29.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/virtua/0.28.0/0.29.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/virtua/0.28.0/0.29.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

@coderabbitai: ignore

---

### Release Notes

<details>
<summary>inokawa/virtua (virtua)</summary>

### [`v0.29.0`](https://togithub.com/inokawa/virtua/releases/tag/0.29.0)

[Compare
Source](https://togithub.com/inokawa/virtua/compare/0.28.0...0.29.0)

**BREAKING CHANGE**: `endMargin` prop was removed because it was no
longer needed!

#### What's Changed

- Refactor startOffset in WindowVirtualizer by
[@&#8203;inokawa](https://togithub.com/inokawa) in
[https://github.com/inokawa/virtua/pull/402](https://togithub.com/inokawa/virtua/pull/402)
- Refactor jump compensation with shift by
[@&#8203;inokawa](https://togithub.com/inokawa) in
[https://github.com/inokawa/virtua/pull/407](https://togithub.com/inokawa/virtua/pull/407)
- Improve jump compensation with shift by
[@&#8203;inokawa](https://togithub.com/inokawa) in
[https://github.com/inokawa/virtua/pull/409](https://togithub.com/inokawa/virtua/pull/409)
- Suppress rerendering of WindowVirtualizer outside of viewport by
[@&#8203;inokawa](https://togithub.com/inokawa) in
[https://github.com/inokawa/virtua/pull/401](https://togithub.com/inokawa/virtua/pull/401)

**Full Changelog**:
inokawa/virtua@0.28.0...0.29.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/cuculus-dev/cuculus).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNDUuMCIsInVwZGF0ZWRJblZlciI6IjM3LjI0NS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant