Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extra assertions and warns #6

Merged
merged 2 commits into from
Dec 19, 2023
Merged

Extra assertions and warns #6

merged 2 commits into from
Dec 19, 2023

Conversation

johnalotoski
Copy link
Contributor

  • Extra assertions to:

    • Prevent lockout from misconfigured gitlab groups
    • Prevent lockouts from not configuring any keys, ex: fail2ban breaking existing conns on a subsequent ssh attempt

  • Extra warnings to:

    • Prevent lockout from local or upstream token breakage when teams or groups are in use
    • Prevent lockout from other edge cases

@dermetfan dermetfan self-requested a review December 19, 2023 09:19
dermetfan
dermetfan reviewed Dec 19, 2023
View reviewed changes
flake.nix Outdated Show resolved Hide resolved
@dermetfan dermetfan added the enhancement New feature or request label Dec 19, 2023
@johnalotoski johnalotoski merged commit 31f8d4e into main Dec 19, 2023
3 checks passed
@dermetfan dermetfan deleted the more-assertions branch December 19, 2023 20:50
@johnalotoski johnalotoski restored the more-assertions branch December 20, 2023 21:29
@johnalotoski johnalotoski deleted the more-assertions branch December 20, 2023 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dermetfan dermetfan dermetfan approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johnalotoski @dermetfan