Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move governance query commands to query command group #347

Merged
merged 5 commits into from
Oct 9, 2023

Conversation

newhoggy
Copy link
Contributor

@newhoggy newhoggy commented Oct 8, 2023

Changelog

- description: |
    Move `governance query` commands to `query` command group
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Resolves #312

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • The change log section in the PR description has been filled in
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • round trip tests
    • integration tests
      See Running tests for more details
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • The changelog section in the PR is updated to describe the change
  • Self-reviewed the diff

@newhoggy newhoggy marked this pull request as ready for review October 8, 2023 12:52
@smelc
Copy link
Contributor

smelc commented Oct 9, 2023

@newhoggy> is this part of fixing #312?

@newhoggy newhoggy added this pull request to the merge queue Oct 9, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Oct 9, 2023
@newhoggy newhoggy added this pull request to the merge queue Oct 9, 2023
Merged via the queue into main with commit 8946a00 Oct 9, 2023
22 checks passed
@newhoggy newhoggy deleted the newhoggy/move-governance-query-commands branch October 9, 2023 14:09
@CarlosLopezDeLara
Copy link
Contributor

CarlosLopezDeLara commented Oct 9, 2023

Nice!


./dist-newstyle/build/x86_64-linux/ghc-9.2.7/cardano-cli-8.12.0.0/x/cardano-cli/build/cardano-cli/cardano-cli conway query
Usage: cardano-cli conway query
                                  ( protocol-parameters
                                  | constitution-hash
                                  | tip
                                  | stake-pools
                                  | stake-distribution
                                  | stake-address-info
                                  | utxo
                                  | ledger-state
                                  | protocol-state
                                  | stake-snapshot
                                  | leadership-schedule
                                  | kes-period-info
                                  | pool-state
                                  | tx-mempool
                                  | slot-number
                                  | constitution
                                  | gov-state
                                  | drep-state
                                  | drep-stake-distribution
                                  | committee-state
                                  )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move cardano-cli conway governance query to cardano-cli <era> query
4 participants