Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align create-constitution anchor flags with other anchor flags #460

Merged
merged 3 commits into from Nov 17, 2023

Conversation

smelc
Copy link
Contributor

@smelc smelc commented Nov 16, 2023

Changelog

- description: |
    Deleted `--constitution-anchor-metadata`
    Delete `--constitution-anchor-metadata-file`
    
    To workaround those deletions, call `cardano-cli conway governance hash ...` and pass the data/file you were previously passing
    to `--constitution-anchor-metadata`/`--constitution-anchor-metadata-file`, then read the result, and feed it
    to the call `cardano-cli conway governance action create-constitution`.

    Renamed `--constitution-anchor-url` to `--constitution-url`
    Renamed `--constitution-anchor-metadata-hash` to `--constitution-hash`
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Fixes #447

How to trust this PR

Usual things:

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@smelc smelc marked this pull request as ready for review November 16, 2023 16:15
@@ -67,6 +71,11 @@ hprop_golden_conway_governance_action_view_constitution_json =

proposalHash <- H.readFile hashFile

constitutionHash <- execCardanoCLI
[ "conway", "governance", "hash"
, "--text", "nonAsciiInput: 你好 and some more: こんにちは"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good idea, testing this as well!

@smelc smelc force-pushed the smelc/governance-hash-write-to-file branch from 6915ec0 to 01e84d7 Compare November 17, 2023 10:09
Base automatically changed from smelc/governance-hash-write-to-file to main November 17, 2023 15:17
@smelc smelc force-pushed the smelc/governance-create-constution-align-flags-with-420 branch from 0bf9b1d to 77236d7 Compare November 17, 2023 18:49
@smelc smelc enabled auto-merge November 17, 2023 18:49
@smelc smelc added this pull request to the merge queue Nov 17, 2023
Merged via the queue into main with commit fa7f72a Nov 17, 2023
19 checks passed
@smelc smelc deleted the smelc/governance-create-constution-align-flags-with-420 branch November 17, 2023 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Align create-constitution flags with --anchor-(url|data-hash) new behavior
2 participants