cardano-cli conway governance action create-constitution: rework hash arguments

[CarlosLopezDeLara]

Remove the metadata word from

--constitution-anchor-url TEXT
( --constitution-anchor-metadata TEXT
| --constitution-anchor-metadata-file FILE
| --constitution-anchor-metadata-hash HASH
)

it should be

--constitution-anchor-url TEXT
( --constitution-anchor-text TEXT
| --constitution-anchor-file FILE
| --constitution-anchor-hash HASH
)

---

[edit]

Update from a discussion on Slack:

• We will have --constitution-anchor-url TEXT --constitution-anchor-hash HASH,
• and a command cardano-cli conway governance hash --file --text to create the HASH

[carlhammann]

@CarlosLopezDeLara, @smelc I'm all for making the flags shorter, but the proposed renaming loses clarity: the file and hash do not include the anchor URL. (An anchor is an URL plus a hash of the contents behind that URL. The text, file, or hash are the options for a "hash source".)

[smelc]

As of dbbc570, commands affected by this change are:

• create-constitution (--proposal-anchor-metadata, --proposal-anchor-metadata-file, --constitution-anchor-metadata, --constitution-anchor-metadata-file)
• update-committee (--proposal-anchor-metadata, --proposal-anchor-metadata-file)
• create-info (same as previous)
• create-no-confidence (same as previous)
• create-protocol-parameters-update (same as previous)
• create-treasury-withdrawal (same as previous)
• conway governance vote create (--vote-anchor-metadata, --vote-anchor-metadata-hash)

[smelc]

I'm nearly done with this (PR 442). In the end I propose we have three modes in the conway governance hash command, like b2sum:

• --text which takes the text to hash directly
• --text-file which takes a file and treats it as text, and hashes its content
• --binary-file which takes a treats it as binary, allowing PDF files, compressed files, etc; and hashes its content.

If we go with only --text and --file, we don't clearly state how we treat files, and will end up with unhappy users. Test-wise, those flags will allow us to be platform-agnostic and avoid failures on Windows.

[Jimbo4350]

#442 (review)

[smelc]

I went for --text, --file-text, and --file-binary in the end, as it looked more consistent with existing flags, that tend to differentiate different behaviors by the suffix of the flag, rather than the start of the flag.

[smelc]

@CarlosLopezDeLara> another side effect of the PR is that I harmonized the flags of anchors of vote create with all the other commands:

• --vote-anchor-url becomes --anchor-url
• --vote-anchor-metadata-hash becomes --anchor-data-hash