Make scripts needed part of utxo class #3019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lehins
force-pushed
the
lehins/make-scripts-needed-part-of-utxo-class
branch
from
6d6d9ea to
e9d86a2
Compare
lehins
force-pushed
the
lehins/make-scripts-needed-part-of-utxo-class
branch
from
e9d86a2 to
8d28956
Compare
JaredCorduan
approved these changes
Sep 12, 2022
lehins
force-pushed
the
lehins/make-scripts-needed-part-of-utxo-class
branch
2 times, most recently
from
49b84e2 to
703e78c
Compare
This approach allows us to move `mintedTxBodyF` into ShelleyMA era, where it belongs. It also unifies the spec and code, where spec uses the same function `scriptsNeeded` in all eras. In order to achieve this we need a special type family `ScriptsNeeded`, since eras do not agree in the return type of the function.
lehins
force-pushed
the
lehins/make-scripts-needed-part-of-utxo-class
branch
from
d6dc552 to
dc29001
Compare
iohk-bors
bot
deleted the
lehins/make-scripts-needed-part-of-utxo-class
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
getScriptsNeededto theEraUTxO:This approach allows us to move
mintedTxBodyFinto ShelleyMA era, where it belongs. It also unifies the spec and code, where spec uses the same functionscriptsNeededin all eras. In order to achieve this we need a special type familyScriptsNeeded, since eras do not agree in the return type of the function.Model testing framework is conflicting with this change and will require significant effort to make it work. At the team level we've already noticed that that framework is starting to bitrot and we agreed to remove it. This PR does that as well.