Split GenState module into three #3020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Soupstraw
approved these changes
Sep 2, 2022
lehins
force-pushed
the
lehins/split-gen-state
branch
from
f319af7 to
d90e7ba
Compare
lehins
changed the title
This was necessary to avoid long compilation times for individual, which triggered CI build timeout on hydra
lehins
force-pushed
the
lehins/split-gen-state
branch
from
d90e7ba to
89b8e9d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like on hydra there is a timeout limit that kills a CI job when there is no output for a certain period of time. It so happens that when GenState module is build on a mac-mini it takes just long enough for the CI job to get terminated during the build phase
A simple solution to this problem is to split the module into two smaller ones, that is what this PR does.