Update plutus version #3030
Closed
Update plutus version #3030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teodanciu
force-pushed
the
td/update-plutus
branch
3 times, most recently
from
13ec291 to
a72e63a
Compare
|
FYI: kapralVV/Unique#10 |
teodanciu
force-pushed
the
td/update-plutus
branch
from
28b96a8 to
aebbc88
Compare
so that running cabal from within the shell doesn't have to (which sometimes fails).
since plutus brings in version 1.4.1.0 but our dependency Unique is restricting it to 1.4.
which was wrong, but only started failing with the new plutus version
teodanciu
force-pushed
the
td/update-plutus
branch
from
96a42c1 to
b581958
Compare
lehins
requested changes
Sep 17, 2022
Comment on lines
+445
to
+446
| PlutusScript PlutusV1 bytes -> (not . null) (PV1.assertScriptWellFormed (transProtocolVersion pv) bytes :: Either ScriptDecodeError ()) | ||
| PlutusScript PlutusV2 bytes -> (not . null) (PV2.assertScriptWellFormed (transProtocolVersion pv) bytes :: Either ScriptDecodeError ()) |
There was a problem hiding this comment.
It is better to use specialized function isRight instead of relying on Foldable instance for Either:
|
Closed it in favor of #2992 |
|
Nice, thank you for making something usable from two partial things! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to isolate changes from #2992, to see what's causing the build error in plutus-core that
cabal build allis attempting to build.Turns out the problem is happening because the
hashablelibrary was upgraded in plutus to 1.4.10, but in our project, thedependency on
Uniqueis restricting the version ofhashableto 1.4. It worked after adding theUnique:hashableto allow-newer in cabal.project.Now that the dependency problems are solved, the remaining issue is adapting to the new code. I have tried (last commit) and might have partially succeeded, but I got stuck at theEDIT: Sorted this out nowValidatorHashtype that seems to have been removed from the API and ran out of time investigating what it was replaced with.I think it would be good to sort this PR out and merge it, and then resume the original prelude-removal one #2992, because the latter depends on this PR.