Adresses issue #3001, Renames AuxiliaryData consistently across eras. #3032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lehins
requested changes
Sep 12, 2022
There was a problem hiding this comment.
This looks great! There are a few lines that were reverted when compared to master during a rebase, but I marked all of them in the comments with concrete diffs that can be applied directly from the PR review.
One more thing is worth doing is a changelog entry, since that will affect downstream users.
eras/shelley-ma/impl/src/Cardano/Ledger/ShelleyMA/AuxiliaryData.hs
Outdated
Show resolved
Hide resolved
teodanciu
reviewed
Sep 12, 2022
eras/shelley/test-suite/src/Test/Cardano/Ledger/Shelley/Examples/Consensus.hs
Show resolved
Hide resolved
teodanciu
reviewed
Sep 12, 2022
eras/shelley/test-suite/test/Test/Cardano/Ledger/Shelley/Serialisation/Tripping/CBOR.hs
Outdated
Show resolved
Hide resolved
TimSheard
force-pushed
the
ts-consistent-auxdata
branch
from
84e3549 to
e003459
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #3001
Renames AuxiliaryData type families consistently across eras to TxAuxData. Actual instances are called
ShelleyTxAuxData
AllegraTxAuxData
AlonzoTxAuxData