9.2.4 compatibility #3041
Merged
9.2.4 compatibility #3041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikd
force-pushed
the
erikd/ghc-9.2
branch
2 times, most recently
from
182a1c7 to
765def1
Compare
erikd
force-pushed
the
erikd/ghc-9.2
branch
4 times, most recently
from
3a487ac to
fa83270
Compare
erikd
force-pushed
the
erikd/ghc-9.2
branch
2 times, most recently
from
6de4e04 to
59e8410
Compare
angerman
commented
Oct 25, 2022
erikd
force-pushed
the
erikd/ghc-9.2
branch
2 times, most recently
from
b663d59 to
36b3bcf
Compare
This was referenced Oct 26, 2022
Closed
Closed
|
I added back @michaelpj's original commentary. |
|
Thanks @michaelpj! |
angerman
force-pushed
the
erikd/ghc-9.2
branch
from
f8760ae to
668d370
Compare
|
The next iteration on this repo, should cut the nix code aggressively for a stock flake if possible. |
|
Some test failures, looks like it's looking for test files in the wrong place. |
|
I pushed the haskell.nix bump that fixes the datadir problem. |
|
The cicero job is broken due to https://input-output.atlassian.net/browse/CIC-246, but Hydra is green. In fact we're about to release a 9.2-compatible plugin, so if we wait a short time then we'll be able to avoid the conditionals an everything. |
* Relax base bounds * Remove redundant constraints. * Replace -Weverything with -Wall. * Remove unused dependencies. * Much more. Co-Authored-By: Moritz Angermann <moritz.angermann@gmail.com> Co-Authored-By: John Ky <john.ky@iohk.io> Co-Authored-By: Michael Peyton Jones <michael.peyton-jones@iohk.io>
|
Went green! |
|
@JaredCorduan I think this is good to go now! |
lehins
approved these changes
Nov 1, 2022
JaredCorduan
approved these changes
Nov 1, 2022
|
Ah indeed, we should mark |
|
🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VERY WIP
Depends on #3098.
This is mostly here to get Hydra building the shell in the background for easier iteration. Then we need to actually push the changes to this branch to get things compiling with 9.2.
This moves the ledger to build primarily with GHC 9.2. I say "primarily", because there annoyingly remains one package that doesn't build with 9.2, namely
plutus-preprocessor. This is because we haven't fixed upplutus-tx-pluginto work with 9.2 yet.The compromise position I've taken is to move the default build environment to 9.2, but leave instructions for how to get an 8.10 shell if you need to use
plutus-preprocessor. This requires us to not break 8.10 support for a while, but hopefully not too long. And it still lets us progress towards a 9.2 node.The alternative would be to just not try to keep 8.10 support at all, and not try to keep
plutus-preprocessorbuilding. Then we would resurrect it once we fixplutus-tx-plugin. I think that's worth considering, since it's not used that frequently and it's not that much code. This approach would allow you to start using 9.2 features everywhere (and give you a simpler CI), but at the cost of losingplutus-preprocessorfor a bit. Up to you.