Redo field updates for faster compile #3044
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Field updates like
Seem to take forever to compile if 'exp' has a complicated type.
Empirical analysis shows that replacing them with simple update functions can dramatically speed things up
for example.
we recombined
Test.Cardano.Ledger.Generic.GenState.Types
,Test.Cardano.Ledger.Generic.GenState.GenScript
, andTest.Cardano.Ledger.Generic.GenState.Generate
intoTest.Cardano.Ledger.Generic.GenState
we also redid
Test.Cardano.Ledger.Generic.TxGen
cardano-ledger-test now cuts approximately 20 minutes from compile time.