Versioned CBOR #3063
Merged
Versioned CBOR #3063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lehins
force-pushed
the
lehins/vcbor-reader
branch
2 times, most recently
from
958efc5 to
44908aa
Compare
TimSheard
approved these changes
Oct 7, 2022
libs/cardano-ledger-binary/src/Cardano/Ledger/Binary/Decoding.hs
Outdated
Show resolved
Hide resolved
libs/cardano-ledger-binary/src/Cardano/Ledger/Binary/Decoding/Coders.hs
Outdated
Show resolved
Hide resolved
libs/cardano-ledger-binary/src/Cardano/Ledger/Binary/Decoding/Decoder.hs
Outdated
Show resolved
Hide resolved
libs/cardano-ledger-binary/test-lib/Test/Cardano/Ledger/Binary/RoundTrip.hs
Outdated
Show resolved
Hide resolved
libs/cardano-ledger-binary/test-lib/Test/Cardano/Ledger/Binary/Twiddle.hs
Show resolved
Hide resolved
lehins
force-pushed
the
lehins/vcbor-reader
branch
2 times, most recently
from
d5aa3b2 to
6091cb2
Compare
This package introduces new `Encoding` and `Decoder` wrappers that can change their behavior depending on a version, which corresponds to major protocol version. This package introduces new conceptws and consolidates all the old ones that were spread around different packages: * Introduced `Version` in its own module and make it safe to construct * Switch from `ReaderT` to manual Version passing to recover representational role * All decoders and encoders as well as `FromCBOR`/`ToCBOR` classes from `cardano-binary` package * Re-exports `Annotator` functionality from `cardano-binary` package, with plans to migrate it completely in the future * Moved dropper from `cardano-binary` * Test suites from `cardano-binary` and `cardano-data` as vintage test suites * `FromSharedCBOR` from `cardano-data` package * `Data.Coders` module from `cardano-data` package * `Data.Twiddler` module from `cardano-data` package into a `test-lib` * Improved Roundtripping tests and sophisticated way to display CBOR encoded blobs that was transferred from `ouroboros-consensus` repo. * Custom decoders/encoders from `Cardano.Ledger.Serialization` module from `cardano-ledger-core` package * Implement round trip test for all To/FromCBOR instances. Discovered major bug with `SlicedByteArray` and fix it in `cborg` package: well-typed/cborg#301
lehins
force-pushed
the
lehins/vcbor-reader
branch
from
79d945f to
59f7c13
Compare
Yes, it does, except only the first half of it. This PR only implements the library that is capable of versioned CBOR. A subsequent PR will be submitted that actually applies this new interface throughout ledger. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Started new package
cardano-ledger-binary:This package introduces new
EncodingandDecoderwrappers that can change their behavior depending on a version, which corresponds to major protocol version. This package introduces new conceptws and consolidates all the old ones that were spread around different packages:Versionin its own module and make it safe to constructReaderTto manual Version passing to recover representational roleFromCBOR/ToCBORclasses fromcardano-binarypackageAnnotatorfunctionality fromcardano-binarypackage, with plans to migrate it completely in the futurecardano-binarycardano-binaryandcardano-dataas vintage test suitesFromSharedCBORfromcardano-datapackageData.Codersmodule fromcardano-datapackageData.Twiddlermodule fromcardano-datapackage into atest-libouroboros-consensusrepo.Cardano.Ledger.Serializationmodule fromcardano-ledger-corepackageSlicedByteArrayand fix it incborgpackage: Fix SlicedByteArray well-typed/cborg#301