Ts new calc pool distr #3068
Merged
Ts new calc pool distr #3068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimSheard
force-pushed
the
ts-new-calcPoolDistr
branch
from
ee9566d to
2fc91e5
Compare
ltouro
reviewed
Oct 10, 2022
eras/shelley/impl/src/Cardano/Ledger/Shelley/LedgerState/IncrementalStake.hs
Outdated
Show resolved
Hide resolved
TimSheard
force-pushed
the
ts-new-calcPoolDistr
branch
2 times, most recently
from
31629c2 to
1609d68
Compare
TimSheard
force-pushed
the
ts-new-calcPoolDistr
branch
2 times, most recently
from
d5a6660 to
8021de1
Compare
JaredCorduan
force-pushed
the
ts-new-calcPoolDistr
branch
from
8021de1 to
a84b583
Compare
JaredCorduan
approved these changes
Oct 26, 2022
There was a problem hiding this comment.
This looks wonderful @TimSheard , thank you for adding in all those very helpful comments!
Do you mind adding notes to #3035 with the results of the benchmarks? it will be really great to have a bit of a record of the results (and the community might be interested to learn as well).
|
So I added some notes to #3035. Did you make some changes. I note that you did a force-push . Do I need to do anything else? (like rebase on master?) |
lehins
requested changes
Oct 26, 2022
eras/shelley/impl/src/Cardano/Ledger/Shelley/LedgerState/IncrementalStake.hs
Outdated
Show resolved
Hide resolved
eras/shelley/impl/src/Cardano/Ledger/Shelley/LedgerState/IncrementalStake.hs
Outdated
Show resolved
Hide resolved
eras/shelley/impl/src/Cardano/Ledger/Shelley/LedgerState/IncrementalStake.hs
Outdated
Show resolved
Hide resolved
eras/shelley/impl/src/Cardano/Ledger/Shelley/LedgerState/IncrementalStake.hs
Outdated
Show resolved
Hide resolved
eras/shelley/impl/src/Cardano/Ledger/Shelley/LedgerState/IncrementalStake.hs
Outdated
Show resolved
Hide resolved
libs/cardano-ledger-test/bench/Bench/Cardano/Ledger/StakeDistr.hs
Outdated
Show resolved
Hide resolved
libs/cardano-ledger-test/bench/Bench/Cardano/Ledger/StakeDistr.hs
Outdated
Show resolved
Hide resolved
libs/cardano-ledger-test/bench/Bench/Cardano/Ledger/StakeDistr.hs
Outdated
Show resolved
Hide resolved
libs/cardano-ledger-test/bench/Bench/Cardano/Ledger/StakeDistr.hs
Outdated
Show resolved
Hide resolved
TimSheard
force-pushed
the
ts-new-calcPoolDistr
branch
4 times, most recently
from
5a8657f to
0a682b9
Compare
TimSheard
force-pushed
the
ts-new-calcPoolDistr
branch
from
e8d6b0f to
5251425
Compare
lehins
approved these changes
Nov 3, 2022
JaredCorduan
force-pushed
the
ts-new-calcPoolDistr
branch
from
5251425 to
ce4375c
Compare
…in terms of time on an actual recent NewEpochState. Add the function runRule to support benchmarking Rule computations in the STS framework. Add many benchmarks, and using that information wrote a few new functions that are more efficient. Added tests that these functions compute the same results. Changed the Arbitrary instance for Stake to enforce Ada is preserved implications, I.e. the sum of Ada in Stake cannot exceed (maxBound :: Word64). We now use newer version of 'cardano-strict-containers'
TimSheard
force-pushed
the
ts-new-calcPoolDistr
branch
from
ce4375c to
186da87
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some benchmarks to speed up the tickf rule