Documented the Twiddler module
#3073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Soupstraw
requested review from
lehins and
TimSheard
and removed request for
lehins
Soupstraw
force-pushed
the
jj/document-twiddle
branch
4 times, most recently
from
fe06283 to
c30043a
Compare
Soupstraw
force-pushed
the
jj/document-twiddle
branch
3 times, most recently
from
ff9e55f to
e6d9eb5
Compare
lehins
reviewed
Oct 11, 2022
libs/cardano-ledger-binary/test-lib/Test/Cardano/Ledger/Binary/Twiddle.hs
Outdated
Show resolved
Hide resolved
libs/cardano-ledger-binary/test-lib/Test/Cardano/Ledger/Binary/Twiddle.hs
Outdated
Show resolved
Hide resolved
libs/cardano-ledger-binary/test-lib/Test/Cardano/Ledger/Binary/Twiddle.hs
Outdated
Show resolved
Hide resolved
|
@Soupstraw FYI I didn't appprove the PR, since it is still marked as "draft". I wasn't sure if you plan to add more to this PR. Also ormolu CI fails |
|
Yes, I figured I'll add some tests for the |
Soupstraw
force-pushed
the
jj/document-twiddle
branch
4 times, most recently
from
ac3dd05 to
e0ca2dc
Compare
Soupstraw
force-pushed
the
jj/document-twiddle
branch
2 times, most recently
from
a01a716 to
5dd714f
Compare
|
It's failing the probabilistic tests again.. |
Soupstraw
changed the title
Twiddler module.Twiddler module
teodanciu
reviewed
Oct 17, 2022
libs/cardano-ledger-binary/test-lib/Test/Cardano/Ledger/Binary/Twiddle.hs
Show resolved
Hide resolved
|
Great documentation, I finally I understand the Twiddler :D |
libs/cardano-ledger-binary/test-lib/Test/Cardano/Ledger/Binary/Twiddle.hs
Outdated
Show resolved
Hide resolved
JaredCorduan
approved these changes
Oct 17, 2022
There was a problem hiding this comment.
I agree with @teodanciu , this looks great! I also really love the new tests!!
Soupstraw
force-pushed
the
jj/document-twiddle
branch
from
5dd714f to
a998778
Compare
JaredCorduan
force-pushed
the
jj/document-twiddle
branch
from
a998778 to
44c270e
Compare
lehins
requested changes
Oct 19, 2022
Soupstraw
force-pushed
the
jj/document-twiddle
branch
2 times, most recently
from
49ef3d8 to
f48bca0
Compare
Soupstraw
force-pushed
the
jj/document-twiddle
branch
from
f48bca0 to
b551bd7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds documentation to the
Twiddlemodule.I also devised a law for
Twiddleinstances and wrote some tests that test that law.closes #3067