Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused Data.BiMap module from cardano-data #3089

Merged
merged 1 commit into from
Oct 21, 2022
Merged

Remove unused Data.BiMap module from cardano-data #3089

merged 1 commit into from
Oct 21, 2022

Conversation

teodanciu
Copy link
Contributor

@teodanciu teodanciu commented Oct 18, 2022 •
edited
Loading

Closes #3086

JaredCorduan
JaredCorduan approved these changes Oct 18, 2022
View reviewed changes
Copy link
Contributor

@JaredCorduan JaredCorduan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Red is the color of ❤️ s. I ❤️ removing dead code! This looks good to me, once we get past the CI failures. thank you!

JaredCorduan
JaredCorduan reviewed Oct 18, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@teodanciu teodanciu force-pushed the td/remove-bimap branch 3 times, most recently from b678b25 to 13caf70 Compare October 19, 2022 13:51
lehins
lehins approved these changes Oct 20, 2022
View reviewed changes
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

CHANGELOG.md Outdated Show resolved Hide resolved
@teodanciu teodanciu force-pushed the td/remove-bimap branch 2 times, most recently from dd5142a to 7c006b0 Compare October 21, 2022 08:58
@teodanciu teodanciu merged commit 8a8daef into master Oct 21, 2022
@iohk-bors iohk-bors bot deleted the td/remove-bimap branch October 21, 2022 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JaredCorduan JaredCorduan JaredCorduan approved these changes

@lehins lehins lehins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove BiMap implementation
3 participants
@teodanciu @JaredCorduan @lehins