Rename UTxOState fields without underscores #3108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aniketd
force-pushed
the
aniketd/issue-3061-utxostate
branch
2 times, most recently
from
6ac47e9
to
c6bdf8c
Compare
JaredCorduan
approved these changes
Oct 31, 2022
teodanciu
reviewed
Oct 31, 2022
lehins
requested changes
Oct 31, 2022
There was a problem hiding this comment.
This is a breaking change and requires a bump in version. So, currently released version of cardano-ledger-shelley is 0.1.0.0, so we need to bump it up to 0.2.0.0. Otherwise it looks great. This is a fairly new process, which we should all adopt
Also, we need to add a changelog to all of our packages and start placing changes there, instead of top level CHNAGELOG file. @aniketd This could be your next task, which you could do in a follow up PR
|
Should we also release the new version to cHaP? |
|
No, we don't need to make a release for every PR. Only when a downstream library is ready to integrate and use the new version, we should make a release
|
lehins
approved these changes
Oct 31, 2022
Update CHANGELOG Run formatter Bump cardano-ledger-shelley version to 0.2.0.0
aniketd
force-pushed
the
aniketd/issue-3061-utxostate
branch
from
53b6cc9
to
c882c04
Compare
|
Done! |
|
@aniketd - this is the most highly approved PR I've seen! 😄 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #3061
- [ ] Add DEPRECATED warning for all renamed fieldsThey won't be useful as setters.- [ ] Open PRs against downstream packages to not use the deprecated accessors.The CHANGELOG update could be enough.