Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move some modules to core Version 4 #3109

Merged
merged 2 commits into from
Oct 31, 2022
Merged

Move some modules to core Version 4 #3109

merged 2 commits into from
Oct 31, 2022

Conversation

TimSheard
Copy link
Contributor

Moved Shelley.Orphans, Shelley.PoolParams and Shelley.EpochBoundary to Cardano.Ledger core.

lehins
lehins requested changes Oct 31, 2022
View reviewed changes
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's great. History is preserved. I can suggest squashing last three commits together, but that is just a suggestion. GHC flag needs fixing though, I left it as a comment on a commit

eras/shelley/impl/src/Cardano/Ledger/Shelley/Orphans.hs Outdated Show resolved Hide resolved
lehins
lehins approved these changes Oct 31, 2022
View reviewed changes
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome

JaredCorduan
JaredCorduan reviewed Oct 31, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@TimSheard
Added deprecated versions of the moved files, that export the new. Ch…
f88bccd 
…anged all the old imports, updated changelog
@TimSheard TimSheard mentioned this pull request Oct 31, 2022
Closed
@TimSheard TimSheard merged commit 6c63540 into master Oct 31, 2022
@iohk-bors iohk-bors bot deleted the ts-toCoreV4 branch October 31, 2022 20:15
@aniketd aniketd mentioned this pull request Mar 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JaredCorduan JaredCorduan JaredCorduan left review comments

@lehins lehins lehins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TimSheard @JaredCorduan @lehins