Move UTxO to Core #3110
Merged
Move UTxO to Core #3110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lehins
approved these changes
Nov 1, 2022
eras/shelley/test-suite/src/Test/Cardano/Ledger/Shelley/Generator/Core.hs
Outdated
Show resolved
Hide resolved
TimSheard
force-pushed
the
ts-moveUTxo-tocore
branch
from
ee156d3
to
ee7e6ab
Compare
|
After some magic, managed to restore the git history to both UTxO filles. |
JaredCorduan
reviewed
Nov 1, 2022
JaredCorduan
approved these changes
Nov 1, 2022
TimSheard
force-pushed
the
ts-moveUTxo-tocore
branch
from
ee7e6ab
to
b5c0559
Compare
lehins
requested changes
Nov 2, 2022
There was a problem hiding this comment.
@TimSheard Squashing all of the commits together erased all of the work you did in the attempt to preserve git history. Are you sure that is what you wanted?
TimSheard
force-pushed
the
ts-moveUTxo-tocore
branch
2 times, most recently
from
72fce81
to
6bdbfa0
Compare
Cardano.Ledger.UTxO that deals with just the UTxO was moved to core
Cardano.Ledger.Shelley.UTxO that deals with Shelley stuff
Both files maintain their git history from the original Cardano.Ledger.Shelley.UTxO
For backwards compatibility The Shelley version exports the core version. We can
change this if we need to.
TimSheard
force-pushed
the
ts-moveUTxo-tocore
branch
from
3bdff87
to
0ca7069
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split the UTxO file in Shelley into two parts.
One that deals just with UTxO Cardano.Ledger.UTxO and the othet which deals with what happens in the
Shelley era, Cardano.Ledger.Shelley.UTxO