Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename {D|P}State fields without underscores #3116

Merged
merged 4 commits into from
Nov 3, 2022

Conversation

aniketd
Copy link
Contributor

@aniketd aniketd commented Nov 2, 2022

Partially addresses #3061

@aniketd aniketd requested review from Soupstraw and lehins November 2, 2022 15:06
@aniketd aniketd changed the title Rename DPState fields without underscores Rename {D|P}State fields without underscores Nov 2, 2022
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. Only thing is missing is a changelog entry

@aniketd
Copy link
Contributor Author

aniketd commented Nov 2, 2022

Oops! I forgot! Let me add it real quick! Sorry!

@aniketd aniketd requested a review from lehins November 3, 2022 09:54
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lehins lehins merged commit 5bb5899 into master Nov 3, 2022
@iohk-bors iohk-bors bot deleted the aniketd/issue-3061-dpstate branch November 3, 2022 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants