Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename AccountState, PoolParams and PoolMetadata fields without underscores #3118

Merged

Conversation

aniketd
Copy link
Contributor

@aniketd aniketd commented Nov 3, 2022

Partially addresses #3061

@aniketd aniketd force-pushed the aniketd/issue-3061-accountstate-poolparams-poolmetadata branch from 77284ee to 7e5bf10 Compare November 3, 2022 12:32
@aniketd aniketd requested a review from lehins November 3, 2022 12:32
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great!!

Copy link
Contributor

@JaredCorduan JaredCorduan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@lehins lehins force-pushed the aniketd/issue-3061-accountstate-poolparams-poolmetadata branch from 7e5bf10 to fc80a62 Compare November 3, 2022 19:18
@aniketd aniketd force-pushed the aniketd/issue-3061-accountstate-poolparams-poolmetadata branch from fc80a62 to 6e36097 Compare November 7, 2022 11:25
@lehins lehins merged commit 836452c into master Nov 7, 2022
@iohk-bors iohk-bors bot deleted the aniketd/issue-3061-accountstate-poolparams-poolmetadata branch November 7, 2022 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants