Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename SnapShot, SnapShots and Certificates.Delegation fields #3120

Merged
merged 1 commit into from
Nov 7, 2022
Merged

Rename SnapShot, SnapShots and Certificates.Delegation fields #3120

merged 1 commit into from
Nov 7, 2022

Conversation

aniketd
Copy link
Contributor

@aniketd aniketd commented Nov 3, 2022

Partially addresses #3061

@aniketd aniketd requested a review from lehins November 3, 2022 15:13
JaredCorduan
JaredCorduan approved these changes Nov 3, 2022
View reviewed changes
Copy link
Contributor

@JaredCorduan JaredCorduan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @aniketd !

lehins
lehins approved these changes Nov 3, 2022
View reviewed changes
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@lehins lehins force-pushed the aniketd/issue-3061-epochboundary-delegationcertificates branch from 668f72a to 720a67b Compare November 3, 2022 19:17
@aniketd aniketd mentioned this pull request Nov 4, 2022
Closed
@aniketd aniketd force-pushed the aniketd/issue-3061-epochboundary-delegationcertificates branch from 720a67b to 45031f3 Compare November 7, 2022 11:10
@lehins
Copy link
Collaborator

lehins commented Nov 7, 2022

Looks like we've got some conflicts

@aniketd aniketd force-pushed the aniketd/issue-3061-epochboundary-delegationcertificates branch from 45031f3 to 2994959 Compare November 7, 2022 13:50
@lehins lehins merged commit b7bb226 into master Nov 7, 2022
@iohk-bors iohk-bors bot deleted the aniketd/issue-3061-epochboundary-delegationcertificates branch November 7, 2022 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JaredCorduan JaredCorduan JaredCorduan approved these changes

@lehins lehins lehins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aniketd @lehins @JaredCorduan