Refactor delegationTransition
#3129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lehins
requested changes
Nov 8, 2022
|
I'll make this work and adapt the suggestions when I'm back on Friday! |
teodanciu
force-pushed
the
andre/deleg-refactor
branch
4 times, most recently
from
64919db to
5b2cd23
Compare
JaredCorduan
approved these changes
Nov 17, 2022
There was a problem hiding this comment.
great cleanup, thank you @teodanciu !
The darwin cicero build is failing with something I don't understand:
F copying 2 paths...
F cardano-protocol-tpraos-lib-cardano-protocol-tpraos> Connection to 10.10.0.2 closed by remote host
F error: unexpected end-of-file
bf5c6e9 to
bd12967
Compare
lehins
approved these changes
Nov 23, 2022
There was a lot of code copy which was in the way of @teodanciu and me figuring out what changes if `allowMIRTransfer` is true or not. We took this as an opportunity for some refactoring. Co-authored-by: teodanciu <teodora.danciu@tweag.io>
to avoid duplication and apply suggested further refactorings
Co-authored-by: Alexey Kuleshevich <alexey.kuleshevich@iohk.io>
teodanciu
force-pushed
the
andre/deleg-refactor
branch
from
846fca8 to
9b8e195
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a lot of code copy which was in the way of @teodanciu and me figuring out what changes if
allowMIRTransferis true or not. We took this as an opportunity for some refactoring.