Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the thunks due to lazy map #3143

Merged
merged 1 commit into from
Nov 16, 2022
Merged

Fix the thunks due to lazy map #3143

merged 1 commit into from
Nov 16, 2022

Conversation

yogeshsajanikar
Copy link
Contributor

  • Use Data.Map.Strict.map instead of lazy <$> to fix the thunk issue

@yogeshsajanikar yogeshsajanikar force-pushed the yogeshs/4006-no-thunk-fix branch from 685fafe to 088b176 Compare November 15, 2022 15:30
@yogeshsajanikar yogeshsajanikar self-assigned this Nov 15, 2022
@lehins lehins mentioned this pull request Nov 15, 2022
Closed
4 tasks
@yogeshsajanikar yogeshsajanikar mentioned this pull request Nov 15, 2022
Open
nfrisby
nfrisby reviewed Nov 16, 2022
View reviewed changes
Copy link
Contributor

@nfrisby nfrisby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👏 (but I'm not Approving, since I'm not an owner here)

@yogeshsajanikar yogeshsajanikar marked this pull request as ready for review November 16, 2022 08:53
lehins
lehins approved these changes Nov 16, 2022
View reviewed changes
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thank you for investigating this

@yogeshsajanikar
Fix the thunks due to lazy map
5d4219a 
- Use Data.Map.Strict.map instead of lazy <$> to fix the thunk issue
@yogeshsajanikar yogeshsajanikar force-pushed the yogeshs/4006-no-thunk-fix branch from 088b176 to 5d4219a Compare November 16, 2022 11:41
@yogeshsajanikar yogeshsajanikar merged commit ba2df7b into master Nov 16, 2022
@iohk-bors iohk-bors bot deleted the yogeshs/4006-no-thunk-fix branch November 16, 2022 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nfrisby nfrisby nfrisby left review comments

@lehins lehins lehins approved these changes

Assignees

@yogeshsajanikar yogeshsajanikar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yogeshsajanikar @nfrisby @lehins